-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable and modernization part 2 #123
Nullable and modernization part 2 #123
Conversation
@FreeAndNil , @fluffynuts - I started a widespread nullable and modernization wave in the code after #119 / #122 , part of which is presented here. If you're willing to accept a series of these, I'm aiming to churn through all the files in the repo to do the same cleanup and optimization. Removing .NET 1.0 |
…h nullable, convert .NET 1 data structures to strongly typed collections, and perform other modernizations
a25f1af
to
6e4a4cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your work.
I've added some remarks and requested some tests (where they are currently missing).
We need to have those methods covered before making changes.
@erikmav Thank you very much (especially for adding the tests). |
@erikmav @fluffynuts I've created issue #124 for those improvements. |
@erikmav did you see my comment regarding the missing test? |
Misunderstood the comment. Working on it. |
Thanks a lot. |
7bde932
into
apache:Feature/111-Dropping-support-for-older-runtimes
Enable nullable annotations for the repo, then update a few files with nullable, convert .NET 1 data structures to strongly typed collections, and perform other modernizations. Plus
#region
removal per a PR comment elsewhere.