Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KnnFloatVectorQuery#toString should show the filter #13983

Closed
jpountz opened this issue Nov 8, 2024 · 2 comments
Closed

KnnFloatVectorQuery#toString should show the filter #13983

jpountz opened this issue Nov 8, 2024 · 2 comments
Labels
type:bug

Comments

@jpountz
Copy link
Contributor

jpountz commented Nov 8, 2024 •
edited
Loading

I was looking at the toString() of a KnnFloatVectorQuery and got surprised that it was not pre-filtered, when I later discovered that it actually was, toString() was just omitting to display the pre-filter.
@viswanathk
Copy link
Contributor

Seems like a good first issue - I can contribute this @jpountz.

viswanathk added a commit to viswanathk/lucene that referenced this issue Nov 12, 2024
@viswanathk
Addresses the issue apache#13983 by adding filter to the toString() m…
c3ce77d 
…ethod of

KnnFloatVectorQuery
viswanathk added a commit to viswanathk/lucene that referenced this issue Nov 12, 2024
@viswanathk
Addresses the issue apache#13983 by adding filter to the toString() m…
4afa128 
…ethod of KnnFloatVectorQuery
viswanathk added a commit to viswanathk/lucene that referenced this issue Nov 12, 2024
@viswanathk
Addresses the issue apache#13983 by adding filter to the toString() m…
461dc99 
…ethod of KnnFloatVectorQuery
viswanathk added a commit to viswanathk/lucene that referenced this issue Nov 12, 2024
@viswanathk
Adding filter to toString() of KnnFloatVectorQuery when it's present …
901f851 
…(addresses apache#13983)
@viswanathk viswanathk mentioned this issue Nov 12, 2024
Merged
viswanathk added a commit to viswanathk/lucene that referenced this issue Nov 18, 2024
@viswanathk
Adding filter to toString() of KnnFloatVectorQuery when it's present …
06a57d6 
…(addresses apache#13983)
benwtrent pushed a commit that referenced this issue Nov 18, 2024
@viswanathk
Adding filter to the toString() method of KnnFloatVectorQuery (#13990)
a991a9a 
* Adding filter to toString() of KnnFloatVectorQuery when it's present (addresses #13983)

* addressing review comments

* adding knnbytevectorquery

* unit test improvements

* tidy

* adding changes entry for the bug fix
benwtrent pushed a commit that referenced this issue Nov 18, 2024
@viswanathk @benwtrent
Adding filter to the toString() method of KnnFloatVectorQuery (#13990)
c96ec0b 
* Adding filter to toString() of KnnFloatVectorQuery when it's present (addresses #13983)

* addressing review comments

* adding knnbytevectorquery

* unit test improvements

* tidy

* adding changes entry for the bug fix
@benwtrent
Copy link
Member

This is now fixed: #13990

benchaplin pushed a commit to benchaplin/lucene that referenced this issue Dec 31, 2024
@viswanathk @benchaplin
Adding filter to the toString() method of KnnFloatVectorQuery (apache…
f0694a0 
…#13990)

* Adding filter to toString() of KnnFloatVectorQuery when it's present (addresses apache#13983)

* addressing review comments

* adding knnbytevectorquery

* unit test improvements

* tidy

* adding changes entry for the bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpountz @viswanathk @benwtrent