-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Arrays.compareUnsigned instead of iterating compare. #13252
Conversation
Please take a look when you get a chance. |
This looks like a good improvement, these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Better replace all those handwritten loops with Arrays methods. We did this for the first time to improve Lucene 8.x with Java9+ (using MR-JAR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @vsop-479! I'll merge soon.
Woops, there are now conflicts here (from the binary search PR) -- maybe you could resolve them @vsop-479, and add a |
I will resolve the conflicts, and try to find other handwritten loops. Thanks @mikemccand @uschindler . |
@mikemccand |
Similar to
SegmentTermsEnumFrame
, we can useArrays.compareUnsigned
instead of iterating compare, inSegmentTermsEnum.seekCeil
andSegmentTermsEnum.seekExact
.