Rename NodeHash to FSTSuffixNodeCache + Javadoc improvement #13259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
Hi Lucene community, would someone kindly take a look at this PR? This is only minor renaming and Javadoc improvement. |
dungba88
changed the title
|
Thanks, this does seem much more explicit and helpful |
benchaplin
pushed a commit
to benchaplin/lucene
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename NodeHash to FSTSuffixNodeCache as NodeHash is rather an obscured name which doesn't tell its exact functionality. I also added the class Javadoc to explain what it is for and how it works, so that it would be easier to follow-up its implementation details (which I often struggled when working on it the first time).