Failing Asserts on .NET Standard 2.x (fixes #267, fixes #301) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightOwl888
changed the title
…estCase on TermVectorsReaders by throwing InvalidOperationException (fixes apache#267)
…apter to 3.16.1, Microsoft.NET.Test.Sdk to 16.6.1 (apache#301)
…ors(): Reflection doesn't throw exceptions when it cannot find a constructor in .NET, we need to test for null instead. (apache#301)
… to supply messages
…ently only support assemblies that are referenced by the calling project.
…ntsWriterInit(): Fixed issue with swallowing NUnit's AssertionException by using Assert.Throws.
… property that can be used to toggle "asserts" on and off in the release build, similar to how it works in Java. The setting can be injected by end users with the "assert" system property (which is a boolean). (apache#301)
… rather than our stock one, that is only meant as a logical default.
NightOwl888
force-pushed
the
fix/failing-asserts
branch
from
defc664 to
ccd4a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #267 by converting these asserts that were intended for control flow during testing into
InvalidOperationExceptions. In the test framework, we are still throwingLucene.Net.Diagnostics.AssertionExceptionin order to differentiate an "assert" from other cases that are throwingInvalidOperationException.This is similar to how Lucene 8.x behaves, and only affects legacy codecs for
Lucene3xandLucene40.As for
BlockTreeTermsWriter, its assert was failing due to lack of validation on thePrefixto ensure it is valid UTF-8. Since the problem is only when building the string in the assert, a private method was added to generate the string by catching exceptions due to invalid UTF-8 and falling back to just writing out the display of bytes inBytesRef.