Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCHECKSTYLE-453] Convert injection to Sisu Guice #160

Merged
merged 9 commits into from
Nov 24, 2024
Merged

[MCHECKSTYLE-453] Convert injection to Sisu Guice #160

merged 9 commits into from
Nov 24, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Nov 21, 2024

No description provided.

@elharo elharo marked this pull request as draft November 21, 2024 10:48
@elharo elharo changed the title Convert LicenseResourceManager to Guice Convert injection to Sisu Guice Nov 21, 2024
@elharo
Copy link
Contributor Author

elharo commented Nov 21, 2024

Error messages is
'

  1. null returned by binding at org.eclipse.sisu.wire.LocatorWiring
    but the 1st parameter of org.apache.maven.plugins.checkstyle.CheckstyleViolationCheckMojo.(Unknown Source) is not @nullable
    at org.eclipse.sisu.wire.LocatorWiring
    while locating org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutor annotated with @com.google.inject.name.Named(value="default")
    for the 1st parameter of org.apache.maven.plugins.checkstyle.CheckstyleViolationCheckMojo.(Unknown Source)

Weird that it says annotated with @com.google.inject.name.Named(value="default") and not annotated with @javax.inject.name.Named(value="default")

@elharo elharo changed the title Convert injection to Sisu Guice [MCHECKSTYLE-453] Convert injection to Sisu Guice Nov 21, 2024
@elharo elharo marked this pull request as ready for review November 21, 2024 15:56
@elharo elharo merged commit 6c1c802 into master Nov 24, 2024
51 checks passed
@elharo elharo deleted the guice3 branch November 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants