Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plugin versions to migrate to Doxia 2 #212

Closed
wants to merge 3 commits into from
Closed

Conversation

slachiewicz
Copy link
Member

Collect plugin upgrades to migrate to Doxia 2 stack.
We could first try to move our Maven projects then later wider for full ASF.

@slachiewicz slachiewicz added the enhancement New feature or request label Nov 3, 2024
@slachiewicz slachiewicz added this to the MAVEN-44 milestone Nov 3, 2024
@slachiewicz slachiewicz marked this pull request as ready for review November 6, 2024 18:51
@slachiewicz slachiewicz requested a review from michael-o November 6, 2024 18:51
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few more updates already, can you fix?

@slachiewicz
Copy link
Member Author

Okay, now all the properties from the parent with Doxia. We may have here a few more.

Are we done with plugin updates for Doxia 2? Do you think this kind of PR makes sense, or can we go with apache-parent update and release?

@slawekjaranowski
Copy link
Member

As I know m-changes-p should be updated ... it is used eg by ASF commons project, commons projects also use own skin ... I think we should help they to migrate

@michael-o
Copy link
Member

Okay, now all the properties from the parent with Doxia. We may have here a few more.

Are we done with plugin updates for Doxia 2? Do you think this kind of PR makes sense, or can we go with apache-parent update and release?

See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack#TowardsDoxia2.0.0Stack-Progress

I would keep it for Maven Parent only before we broaden the scope.

@michael-o
Copy link
Member

michael-o commented Nov 9, 2024

As I know m-changes-p should be updated ... it is used eg by ASF commons project, commons projects also use own skin ... I think we should help they to migrate

  • Maven Changes Plugin: https://lists.apache.org/thread/pgj1gd75hx1dhq9spnl3c70xxt07corx I have a private talk with @garydgregory and @ottlinger how to move forward here. I love the plugin, but too much effort with the current state. There is a workaround with post-site phase and Ant regex replacement to make it work.
  • Commons Skin: This one was doomed for a long time. It is a fork from an old Fluido skin version which has never merged back our changes. I recommended @GaryGregory either rebase on top of Fluido 2.0.0, drop it, or work our the diffs and see whether we could add into Fluido.

@ottlinger
Copy link

Creadur RAT uses Maven changes plugin to generate the release mail and a webpage report of all the stuff that happened within a release including links to Jira, so I'm happy for a way forward here .... other reports are not working as can be see by comparing:

Multiple reports have broken layout, such as:

@michael-o
Copy link
Member

Creadur RAT uses Maven changes plugin to generate the release mail and a webpage report of all the stuff that happened within a release including links to Jira, so I'm happy for a way forward here .... other reports are not working as can be see by comparing:

Multiple reports have broken layout, such as:

Read my workaround above.

@slachiewicz
Copy link
Member Author

Okay, now all the properties from the parent with Doxia. We may have here a few more.
Are we done with plugin updates for Doxia 2? Do you think this kind of PR makes sense, or can we go with apache-parent update and release?

See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack#TowardsDoxia2.0.0Stack-Progress

I would keep it for Maven Parent only before we broaden the scope.

Progress
Necessary changes performed at our (reporting) plugins

Format: {repository}: {branch-for-doxia-1.x}; {branch-for-doxia-2.0.0}

maven-help-plugin: maven-help-plugin-3.4.x; master
maven-project-info-reports-plugin: maven-project-info-reports-plugin-3.6.x; master
maven-invoker-plugin: maven-invoker-plugin-3.7.x; mater
maven-dependency-plugin: maven-dependency-plugin-3.7.x; master
maven-plugin-tools: maven-plugin-tools-3.14.x; master
maven-jxr: jxr-3.4.x; master
maven-pmd-plugin: maven-pmd-plugin-3.24.x; master
maven-javadoc-plugin: maven-javadoc-plugin-3.8.x; master
maven-checkstyle-plugin: maven-checkstyle-plugin-3.4.x; master
maven-surefire: surefire-3.4.x; master
Note: other reporting plugin will not be upgraded.

@slawekjaranowski
Copy link
Member

maven-help-plugin - doesn't has a reports, so do not depends on doxia

@michael-o
Copy link
Member

maven-help-plugin - doesn't has a reports, so do not depends on doxia

Because it uses the Maven Reporting API.

@gnodet gnodet requested a review from michael-o December 7, 2024 16:26
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of them already have newer versions, I'd use them.

@slachiewicz slachiewicz closed this Dec 8, 2024
@slachiewicz
Copy link
Member Author

It would be easier to copy properties from the original parent pom and then let Dependabot open PRs with the latest versions, so we will also have Release Notes oob.

@slawekjaranowski
Copy link
Member

I think that will be a time to also update a ASF parent - one used plugin which has no updates to doxia 2.x was changes ... but it is under vote

@slawekjaranowski slawekjaranowski removed this from the MAVEN-44 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants