vuln-fix: Temporary File Information Disclosure

This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#18 Co-authored-by: Moderne <[email protected]> This closes #160
apache · Mar 12, 2023 · 4402491 · 4402491
1 parent 53abf9a
commit 4402491
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...lease-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java b/...lease-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
@@ -27,6 +27,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.nio.file.Files;
 import java.util.List;
 
 import org.apache.maven.settings.io.xpp3.SettingsXpp3Writer;
@@ -83,7 +84,7 @@ public void executeGoals(
         if (releaseEnvironment.getSettings() != null) {
             // Have to serialize to a file as if Maven is embedded, there may not actually be a settings.xml on disk
             try {
-                settingsFile = File.createTempFile("release-settings", ".xml");
+                settingsFile = Files.createTempFile("release-settings", ".xml").toFile();
                 SettingsXpp3Writer writer = getSettingsWriter();
 
                 try (FileWriter fileWriter = new FileWriter(settingsFile)) {

diff --git a/...ease-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java b/...ease-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
@@ -25,6 +25,7 @@
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -86,7 +87,7 @@ public void executeGoals(
         if (releaseEnvironment.getSettings() != null) {
             // Have to serialize to a file as if Maven is embedded, there may not actually be a settings.xml on disk
             try {
-                settingsFile = File.createTempFile("release-settings", ".xml");
+                settingsFile = Files.createTempFile("release-settings", ".xml").toFile();
                 SettingsXpp3Writer writer = getSettingsWriter();
 
                 try (FileWriter fileWriter = new FileWriter(settingsFile)) {