Update build plugins #129
Merged
Update build plugins #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Oct 6, 2021
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jxr-plugin</artifactId> | ||
| <version>3.1.1</version> |
There was a problem hiding this comment.
This is used twice, make it a property
There was a problem hiding this comment.
This above is in pluginMgmt, and removed the version from one in profile, as it will use the value from pluginMgmt.
|
@michael-o ping |
slachiewicz
approved these changes
Oct 12, 2021
cstamas
added a commit
to apache/maven-parent
that referenced
this pull request
Oct 14, 2021
Enforcer as is causes that downstream in case of update POM must completely redefine plugin, thus, loosing all the benefits of parent POM pluginMgmt. Move plugin definition to pluginMgmt instead to fully define it and it's dependines in plugin section. Keep execution in plugin section. Update to latest enforcer as well. ------ See for example apache/maven-resolver#129
Make it clear that "it only works with Sisu" is meant for integrators, not "end users" wishing to use them with Maven.
I am really unsure why we do this and do we do this right at all. So am not toching this plugin for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update plugins. Enforcer is tricky, as it was in pluginMgmt, but in parent is in plugins, and extra rules are not picked up otherwise.