Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-432] Introduce Session Supplier similar to System Supplier #362

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 14, 2023

Changes:

  • introduce session supplier
  • convert all the demos to v2 session handling
  • add data and cache suppliers to builder
  • fix builder bugs (data, sessionId, properties handling)

https://issues.apache.org/jira/browse/MRESOLVER-432

@cstamas cstamas self-assigned this Nov 14, 2023
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixed bugs:
* builder was building _same instance_ over and over again
* improved data and sessionId handling.
Also fix shared properties, another bug in builder.
This streamlines some logic.
@cstamas cstamas merged commit 2fa9af7 into apache:master Nov 14, 2023
4 checks passed
@cstamas cstamas deleted the MRESOLVER-432 branch November 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants