Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-440] Clean up transport names and config keys #375

Merged
merged 26 commits into from
Nov 26, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 20, 2023

Clean up transport names, also fix problem (historical) where config is related to "connector", as these are since then "transports" and there is one connector provided OOTB in resolver. Finally, solve documentation for config properties.

Along actual cleanup, class and transport renames and key renames, all the config properties have been documented (mostly using javadoc) and also a "tool" has been implemented that can be used to generate configuration reference page, so no more manual authoring needed.


https://issues.apache.org/jira/browse/MRESOLVER-440

@cstamas cstamas self-assigned this Nov 20, 2023
@cstamas cstamas requested a review from michael-o November 20, 2023 21:36
@cstamas
Copy link
Member Author

cstamas commented Nov 20, 2023

Doco is not yet updated...

@michael-o michael-o marked this pull request as draft November 21, 2023 12:10
@cstamas cstamas changed the title [MRESOLVER-440] Clean up transport names [MRESOLVER-440] Clean up transport names and config keys Nov 22, 2023
@cstamas cstamas requested a review from michael-o November 24, 2023 21:30
@cstamas cstamas marked this pull request as ready for review November 25, 2023 19:25
@cstamas cstamas merged commit 6a79195 into apache:master Nov 26, 2023
4 checks passed
@cstamas cstamas deleted the MRESOLVER-440 branch November 26, 2023 15:04
sschuberth pushed a commit to oss-review-toolkit/ort that referenced this pull request Jul 6, 2024
Note that `maven-resolver-transport-http` has been renamed to
`maven-resolver-transport-apache`, see [1].

[1]: apache/maven-resolver#375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants