Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9.x] [MRESOLVER-571] Import o.e.aether packages with the exact same version #507

Merged

Conversation

HannesWell
Copy link
Contributor

The documentation states that only maven-resolver artifacts of the exact same version should be used together.

With this change all org.eclipse.aether* packages are now imported with a strict version range of
'org.eclipse.aether*;version="[@version,@version]"'
Fixes https://issues.apache.org/jira/browse/MRESOLVER-571

This PR currently also containes the changes planned for #505.
If there is agreement for this change, I'll forward port it to the master/2.x.

@HannesWell
Copy link
Contributor Author

Turned it into a draft for now since it contains the changes for #505. Just to ensure it is not accidentally submitted with that.

@HannesWell HannesWell force-pushed the maven-resolver-1.9.x-571 branch 2 times, most recently from 18f5777 to cc2f321 Compare June 26, 2024 07:13
@gnodet gnodet changed the title [MRESOLVER-571] Import o.e.aether packages with the exact same version [1.9.x] [MRESOLVER-571] Import o.e.aether packages with the exact same version Jun 27, 2024
@HannesWell HannesWell force-pushed the maven-resolver-1.9.x-571 branch from cc2f321 to 5301d0a Compare June 28, 2024 07:08
@HannesWell HannesWell marked this pull request as ready for review June 28, 2024 07:08
@gnodet
Copy link
Contributor

gnodet commented Jul 1, 2024

@HannesWell can you double check the merge ?

@HannesWell HannesWell force-pushed the maven-resolver-1.9.x-571 branch from a630381 to 4962800 Compare July 1, 2024 07:48
The documentation states that only maven-resolver artifacts of the exact
same version should be used together.

With this change all org.eclipse.aether* packages are now imported with
a strict version range of
'org.eclipse.aether*;version="[@Version,@Version]"'

Fixes https://issues.apache.org/jira/browse/MRESOLVER-571
@HannesWell HannesWell force-pushed the maven-resolver-1.9.x-571 branch from 4962800 to 2061918 Compare July 1, 2024 09:01
@HannesWell
Copy link
Contributor Author

@HannesWell can you double check the merge ?

I double checked the merge, respectively rebased this branch on top of the current maven-resolver-1.9.x branch.
Then I checked the result of the combined Manifest changes applied recently and all looks as expected, except for the application of the -noimport directive done in this PR. As stated in BND doc for the Export-Package header that directive has to be applied "on the export instruction". I fixed that for this PR already and provide a follow-up on #520 for the master branch.

For me this is now ready. Thanks for all of your reviews.

@gnodet gnodet merged commit f14ed82 into apache:maven-resolver-1.9.x Jul 1, 2024
11 checks passed
@HannesWell HannesWell deleted the maven-resolver-1.9.x-571 branch July 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants