Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7329] Upgrade maven-enforcer-plugin #608

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Nov 10, 2021

This is required in order to be able to build master with itself.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@mthmulders
Copy link
Contributor

Is this a work-around for the fact that apache/maven-parent#32 has not yet been released? Based on what @cstamas said in MNG-7319, I guess that latter is the long-term fix.

@gnodet
Copy link
Contributor Author

gnodet commented Nov 10, 2021

Is this a work-around for the fact that apache/maven-parent#32 has not yet been released? Based on what @cstamas said in MNG-7319, I guess that latter is the long-term fix.

This definitely is the same issue, I missed it as I have been looking for a PR.
Imho, having master not building correctly should be fixed asap, so what about quickly include this PR and eventually revert when maven-parent is released ?

@mthmulders
Copy link
Contributor

Imho, having master not building correctly should be fixed asap

Most certainly agree. We shouldn't even let it come this far (but that's a different topic).

What about quickly include this PR and eventually revert when maven-parent is released?

I don't know how much work it would be to release maven-parent. I feel that would be "the right way" to solve it. But updating it for Maven only (as this PR does) is most likely the fastest way forward. The only thing I'm afraid of is that we will forget to remove this quick patch when maven-parent is released...

@slawekjaranowski
Copy link
Member

We have also m-e-p version in ASF parent pom

and was updated apache/maven-apache-parent@9e195c8

@gnodet
Copy link
Contributor Author

gnodet commented Nov 10, 2021

But updating it for Maven only (as this PR does) is most likely the fastest way forward. The only thing I'm afraid of is that we will forget to remove this quick patch when maven-parent is released...

I've raised https://issues.apache.org/jira/browse/MNG-7330 to not forget it.

Copy link
Contributor

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gnodet gnodet merged commit a748596 into apache:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants