Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executeRemoteCommand does not respect charset arg #597

Closed
metametadata opened this issue Sep 7, 2024 · 0 comments
Closed

executeRemoteCommand does not respect charset arg #597

metametadata opened this issue Sep 7, 2024 · 0 comments
Assignees
@tomaswolf
Labels
bug An issue describing a bug in the code
Milestone
2.14.0

Comments

@metametadata
Copy link

metametadata commented Sep 7, 2024 •
edited
Loading

Version

2.13.2

Bug description

Looking at the impl of executeRemoteCommand(String command, OutputStream stdout, OutputStream stderr, Charset charset), charset argument is not respected as it's not passed into the channel creation method:

mina-sshd/sshd-core/src/main/java/org/apache/sshd/client/session/ClientSession.java

Line 295 in f039b68

default void executeRemoteCommand(

Screenshot 2024-09-07 at 03 53 33
@tomaswolf tomaswolf added the bug An issue describing a bug in the code label Sep 7, 2024
@tomaswolf tomaswolf self-assigned this Sep 7, 2024
@tomaswolf tomaswolf added this to the 2.14.0 milestone Sep 7, 2024
tomaswolf added a commit that referenced this issue Sep 7, 2024
@tomaswolf
GH-597: pass on Charset in ClientSession.executeRemoteCommand()
8db5cad 
Bug: #597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaswolf tomaswolf

Labels
bug An issue describing a bug in the code
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@metametadata @tomaswolf