This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Proposal: Generalize broadcast_like #11871
Labels
Comments
Sounds reasonable to me. |
@sbodenstein I was working on broadcast_like briefly a few weeks ago (#11443 ). This specs looks very reasonable. I am just wondering if you would be comfortable that I work on top of @ifeherva new broadcast_like, and generalize it as discussed above? |
@rondogency: @ifeherva had also expressed interest to implement it, but whoever has more time this week should probably do it (we need it for next Monday, so I would add it neither of you has time this week). |
I see. I won't be available for it until Saturday. If you need it by Monday, I may not be able to make it on time. Sorry for the inconvenience. |
ifeherva
added a commit
to ifeherva/incubator-mxnet
that referenced
this issue
Aug 1, 2018
ifeherva
added a commit
to ifeherva/incubator-mxnet
that referenced
this issue
Aug 18, 2018
szha
pushed a commit
that referenced
this issue
Aug 23, 2018
* Added input_axes and other_axes to broadcast_like See #11871 * Added a simple sanity test * Fixed linting * Fixed linting issues * Renamed parameters, added negative indexing, more testcases * Fixed linting * Replaced params with optionals Not specified axes will result into whole shape, empty tuples shall raise exception. Added tests * Re-added the default param values * Fixed indentation
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this issue
Aug 29, 2018
* Added input_axes and other_axes to broadcast_like See apache#11871 * Added a simple sanity test * Fixed linting * Fixed linting issues * Renamed parameters, added negative indexing, more testcases * Fixed linting * Replaced params with optionals Not specified axes will result into whole shape, empty tuples shall raise exception. Added tests * Re-added the default param values * Fixed indentation
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this issue
Sep 19, 2018
* Added input_axes and other_axes to broadcast_like See apache#11871 * Added a simple sanity test * Fixed linting * Fixed linting issues * Renamed parameters, added negative indexing, more testcases * Fixed linting * Replaced params with optionals Not specified axes will result into whole shape, empty tuples shall raise exception. Added tests * Re-added the default param values * Fixed indentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Now that
broadcast_like
has been merged (#11820), I would like to discuss the extension discussed here by @taliesinb. Quoting it:I would like to open this design up for discussion.
@ifeherva
The text was updated successfully, but these errors were encountered: