This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MKLDNN] reorder the mem format for the AddBack mode in case src & dst is different #11095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MKL-DNN backend, the case is not covered that the src format is not as same as dst format for the AddBack mode. So the crash is observed in example/reinforcement-learning/a3c.
Therefore, the fix is to reorder the src format to dst format when the difference is detected.
The A3C case can pass with the fix. And verified the performance by benchmark_score.py, there's no performance effect.
@zheng-da @TaoLv
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments