-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@junrushao1994 For review if you have time. |
cc @sxjscience |
@zhanghang1989 FYI |
642dce3
to
d1a215b
Compare
2ed60e4
to
660456b
Compare
@haojin2 can you check why unitest is failing? |
@zhreshold Looking into it... |
@zhreshold The failure is on fp16 data type, previously it could endure 10000 trials on my end and now it could not, I'm looking into the issue. |
2b4b2ba
to
794e919
Compare
f175858
to
622f7ce
Compare
e91b389
to
6f52891
Compare
@haojin2 is CI still failing? |
Is there an issue related to CI failing? |
@sxjscience @zhreshold Could you please review this PR again? @haojin2 Could you please re-trigger the CI and look into failure ? Thanks |
@zhreshold @Jerryzcn @sxjscience @eric-haibin-lin CI passed, ready for merge |
I'll merge first. Need to make a PR to revise the test_util + add test for grad_req=kAddTo. Let's make sure all OPs are tested for grad_req=kAddTo (Need to combine the efforts with DeepNumpy). |
* GroupNorm * add to amp list * re-write forward
Description
Group Normalization
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
Related:
#14196 #11283
Flakiness Checks: