Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix print_summary bug and add groups of convolution #9492

Merged
merged 8 commits into from
Feb 19, 2018
Merged

fix print_summary bug and add groups of convolution #9492

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56615e8
fix print_summary bug and add groups of convolution
chinakook Jan 19, 2018
34294b1
Update visualization.py
chinakook Jan 19, 2018
50f0c4c
Update visualization.py
chinakook Jan 22, 2018
ff3a869
Update visualization.py
chinakook Feb 5, 2018
95811c1
Update visualization.py
chinakook Feb 7, 2018
4d36fea
Update visualization.py
chinakook Feb 8, 2018
9bb2573
Update visualization.py
chinakook Feb 17, 2018
52624d4
Update visualization.py
chinakook Feb 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions python/mxnet/visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,26 @@ def print_layer_summary(node, out_shape):
pre_filter = pre_filter + int(shape[0])
cur_param = 0
if op == 'Convolution':
if ("no_bias" in node["attrs"]) and int(node["attrs"]["no_bias"]):
cur_param = pre_filter * int(node["attrs"]["num_filter"])
if "no_bias" in node["attrs"] and node["attrs"]["no_bias"] == 'True':
num_group = int(node["attrs"]["num_group"]) if \
"num_group" in node["attrs"] else 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int(node['attrs'].get('num_group', '1')). same below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dict.get handles default value for missing value so the trailing if is no longer necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

cur_param = pre_filter * int(node["attrs"]["num_filter"]) \
// num_group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the outer parentheses are not necessary and make it hard to read. would you clean it up?

for k in _str2tuple(node["attrs"]["kernel"]):
cur_param *= int(k)
else:
cur_param = pre_filter * int(node["attrs"]["num_filter"])
num_group = int(node["attrs"]["num_group"]) if \
"num_group" in node["attrs"] else 1
cur_param = pre_filter * int(node["attrs"]["num_filter"]) \
// num_group
for k in _str2tuple(node["attrs"]["kernel"]):
cur_param *= int(k)
cur_param += int(node["attrs"]["num_filter"])
elif op == 'FullyConnected':
if ("no_bias" in node["attrs"]) and int(node["attrs"]["no_bias"]):
cur_param = pre_filter * (int(node["attrs"]["num_hidden"]))
if "no_bias" in node["attrs"] and node["attrs"]["no_bias"] == 'True':
cur_param = pre_filter * int(node["attrs"]["num_hidden"])
else:
cur_param = (pre_filter+1) * (int(node["attrs"]["num_hidden"]))
cur_param = (pre_filter+1) * int(node["attrs"]["num_hidden"])
elif op == 'BatchNorm':
key = node["name"] + "_output"
if show_shape:
Expand Down