-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-14005 - GetFileResource processor #9519
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @pvillard31. It looks like a good approach in general, I noted a handful of minor adjustments.
...andard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFileResource.java
Outdated
Show resolved
Hide resolved
Thanks for the review @exceptionfactory - I pushed a commit to address your comments |
Thank you for the addition @pvillard31. I just wondered, Is there a particular reason to have a distinct property for adding a Just trying to understand, is there a reason we explicitly want / need a property for this particular attribute? |
Summary
NIFI-14005 - GetFileResource processor
The goal of this new GetFileResource processor is to provide a way for a user to inject a File Resource as a FlowFile with custom attributes. It means that the processor would be able to specify a path to a file and its content would be used as FlowFile's content. By leveraging the asset feature, it makes it easy to load a test dataset as a FlowFile in a cloud native environment (container based).
Alternatives that have been considered:
Testing:
For information:
The parameter
#{MyAsset}
can then be used in the processor (assuming proper Parameter Context binding on the Process Group).Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation