-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1458: Reduce HDFS NameNode getFileInfo RPC #1767
Open
cxzl25
wants to merge
5
commits into
apache:main
Choose a base branch
from
cxzl25:ORC-1458
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−5
Open
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
java/core/src/java/org/apache/orc/util/OrcInputStreamUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.orc.util; | ||
|
||
import org.apache.hadoop.fs.FSDataInputStream; | ||
|
||
import java.io.InputStream; | ||
import java.lang.reflect.InvocationTargetException; | ||
import java.lang.reflect.Method; | ||
|
||
public class OrcInputStreamUtil { | ||
|
||
private static final String DFS_CLASS = "org.apache.hadoop.hdfs.DFSInputStream"; | ||
private static final String DFS_STRIPED_CLASS = "org.apache.hadoop.hdfs.DFSStripedInputStream"; | ||
|
||
private static Method shortCircuitForbiddenMethod; | ||
private static Method getFileLengthMethod; | ||
|
||
static { | ||
init(); | ||
} | ||
|
||
private static void init() { | ||
try { | ||
initInt(); | ||
} catch (ClassNotFoundException | NoSuchMethodException ignored) { | ||
} | ||
} | ||
|
||
private static void initInt() throws ClassNotFoundException, NoSuchMethodException { | ||
Class<?> dfsClass = Class.forName(DFS_CLASS); | ||
shortCircuitForbiddenMethod = dfsClass.getDeclaredMethod("shortCircuitForbidden"); | ||
shortCircuitForbiddenMethod.setAccessible(true); | ||
getFileLengthMethod = dfsClass.getMethod("getFileLength"); | ||
} | ||
|
||
public static long getFileLength(FSDataInputStream file) { | ||
try { | ||
return getFileLengthInt(file); | ||
} catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException e) { | ||
return -1L; | ||
} | ||
} | ||
|
||
private static long getFileLengthInt(FSDataInputStream file) | ||
throws NoSuchMethodException, InvocationTargetException, IllegalAccessException { | ||
if (shortCircuitForbiddenMethod == null || getFileLengthMethod == null) { | ||
return -1L; | ||
} | ||
InputStream wrappedStream = file.getWrappedStream(); | ||
Class<? extends InputStream> wrappedStreamClass = wrappedStream.getClass(); | ||
String className = wrappedStreamClass.getName(); | ||
if (!className.equals(DFS_CLASS) && !className.equals(DFS_STRIPED_CLASS)) { | ||
return -1L; | ||
} | ||
boolean isUnderConstruction = (boolean) shortCircuitForbiddenMethod.invoke(wrappedStream); | ||
// If file are under construction, we need to get the file length from NameNode. | ||
if (!isUnderConstruction) { | ||
return (long) getFileLengthMethod.invoke(wrappedStream); | ||
} | ||
return -1L; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we reflect this when Apache ORC can access this directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.apache.hadoop.hdfs.DFSInputStream.shortCircuitForbidden
Method is not public.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before ORC-1430, we could not access hdfs-related classes in the core module, so I used reflection.
Now I have done some refactoring, but the method of
shortCircuitForbidden
is not public, so I still need to use reflection.