Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-11968. Only check sibling headings for duplicate titles in markdown lint. #117

Merged
merged 2 commits into from
Dec 19, 2024
Merged

HDDS-11968. Only check sibling headings for duplicate titles in markdown lint. #117

merged 2 commits into from
Dec 19, 2024

Conversation

errose28
Copy link
Contributor

What changes were proposed in this pull request?

Markdownlint has a check for duplicate headings, but by default it is global. We only want to enforce this for sibling headings, for example the following it ok:

# Title
## Case 1
### Usage
## Case 2
### Usage

What is the link to the Apache Jira?

HDDS-11968

How was this patch tested?

Markdownlint check passed in this run, which had duplicate non-sibling headings added here

@errose28 errose28 requested a review from adoroszlai December 19, 2024 21:19
@github-actions github-actions bot added the website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch label Dec 19, 2024
@errose28
Copy link
Contributor Author

@Eric977 this will fix the error you were seeing in #116

adoroszlai
adoroszlai reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @errose28 for the fix.

.markdownlint.yaml Outdated Show resolved Hide resolved
@errose28 errose28 merged commit c07d44f into apache:HDDS-9225-website-v2 Dec 19, 2024
12 checks passed
@errose28
Copy link
Contributor Author

Thanks @adoroszlai for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees
No one assigned
Labels
website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errose28 @adoroszlai