Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-12001. Create parent class for repair tools #7633

Merged
merged 1 commit into from
Jan 3, 2025
Merged

HDDS-12001. Create parent class for repair tools #7633

merged 1 commit into from
Jan 3, 2025

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Introduce parent class for repair tools where common logic can be added later:

  • Move up out() and err() from RecoverSCMCertificate
  • Add methods to show informational and error messages

Additional minor cleanup:

  • Ensure OM client is closed in QuotaTrigger
  • Remove unused methods from TransactionInfoRepair

https://issues.apache.org/jira/browse/HDDS-12001

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/12583280950

@adoroszlai adoroszlai added the tools Tools that helps with debugging label Jan 2, 2025
@adoroszlai adoroszlai self-assigned this Jan 2, 2025
@adoroszlai
Copy link
Contributor Author

@sarvekshayr @Tejaskriya please review

nandakumar131
nandakumar131 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@errose28 errose28 mentioned this pull request Jan 2, 2025
Merged
Tejaskriya
Tejaskriya approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@Tejaskriya Tejaskriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @adoroszlai, LGTM!

sarvekshayr
sarvekshayr approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@sarvekshayr sarvekshayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM +1.

@nandakumar131 nandakumar131 merged commit 47c1b35 into apache:master Jan 3, 2025
42 checks passed
@nandakumar131
Copy link
Contributor

Thanks @adoroszlai for the contribution and thanks to @Tejaskriya & @sarvekshayr for the review!

@adoroszlai adoroszlai deleted the HDDS-12001 branch January 3, 2025 07:55
@adoroszlai
Copy link
Contributor Author

Thanks @nandakumar131, @sarvekshayr, @Tejaskriya for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tejaskriya Tejaskriya Tejaskriya approved these changes

@sarvekshayr sarvekshayr sarvekshayr approved these changes

@nandakumar131 nandakumar131 nandakumar131 approved these changes

@errose28 errose28 Awaiting requested review from errose28

Assignees

@adoroszlai adoroszlai

Labels
tools Tools that helps with debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adoroszlai @nandakumar131 @sarvekshayr @Tejaskriya