GH-3007: Ensure version specific Jackson classes are shaded (#3017)

apache · Sep 25, 2024 · fcfd427 · fcfd427
1 parent ac6a5a0
commit fcfd427
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/parquet-jackson/pom.xml b/parquet-jackson/pom.xml
@@ -97,6 +97,26 @@
                   <pattern>${jackson.package}</pattern>
                   <shadedPattern>${shade.prefix}.${jackson.package}</shadedPattern>
                 </relocation>
+                <relocation>
+                  <pattern>META-INF.versions.9.${jackson.package}</pattern>
+                  <shadedPattern>META-INF.versions.9.${shade.prefix}.${jackson.package}</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>META-INF.versions.11.${jackson.package}</pattern>
+                  <shadedPattern>META-INF.versions.11.${shade.prefix}.${jackson.package}</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>META-INF.versions.17.${jackson.package}</pattern>
+                  <shadedPattern>META-INF.versions.17.${shade.prefix}.${jackson.package}</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>META-INF.versions.19.${jackson.package}</pattern>
+                  <shadedPattern>META-INF.versions.19.${shade.prefix}.${jackson.package}</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>META-INF.versions.21.${jackson.package}</pattern>
+                  <shadedPattern>META-INF.versions.21.${shade.prefix}.${jackson.package}</shadedPattern>
+                </relocation>
               </relocations>
             </configuration>
           </execution>

diff --git a/pom.xml b/pom.xml
@@ -67,6 +67,7 @@
     <jackson.groupId>com.fasterxml.jackson.core</jackson.groupId>
     <jackson.datatype.groupId>com.fasterxml.jackson.datatype</jackson.datatype.groupId>
     <jackson.package>com.fasterxml.jackson</jackson.package>
+    <!-- To upgrade jackson, check the jdk versions inside the jar and include any new versions in the shading in parquet-jackson. -->
     <jackson.version>2.17.2</jackson.version>
     <jackson-databind.version>2.17.2</jackson-databind.version>
     <japicmp.version>0.21.0</japicmp.version>