Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2959: Optimize the test case of parquet rewriter. #2960

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

joyCurry30
Copy link
Contributor

@joyCurry30 joyCurry30 commented Jul 17, 2024

Rationale for this change

Refer to #2959

What changes are included in this PR?

Optimize the test case of parquet rewriter.

Are these changes tested?

Yes.

Are there any user-facing changes?

No,

Closes #2959

@wgtmac
Copy link
Member

wgtmac commented Jul 18, 2024

Thanks for the improvement! Could you please also show the elapsed time of the improved test before and after?

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left some minor comments.

@joyCurry30
Copy link
Contributor Author

Before:
image

After:
image

@wgtmac wgtmac merged commit c928c4b into apache:master Jul 23, 2024
9 checks passed
@wgtmac wgtmac added this to the 1.15.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Optimize the ParquetRewriterTest
2 participants