chore: Fix scala constructor finding tests for scala 3. #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this one can be backported to 1.0.x too. |
|
Scala 3 encoding different vs Scala 2, updating :( |
|
unfortunately our PR build does not test this code - so let's get it merged to main when it is ready but then we run the nightly build We can backport when we know that the main branch nightly tests pass. |
|
@pjfanning The constructor encoding is different in Scala 3 and Scala 2, so I just move these classes to an object , and let them then closing over nothing. |
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Mar 24, 2024
* chore: Fix scala constructor finding tests for scala 3. * reorder imports (cherry picked from commit c818001)
He-Pin
added a commit
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix #1082