-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PIP-180 Part V, Support shadow topic creation.
- Loading branch information
Showing
14 changed files
with
390 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ShadowManagedLedgerImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.bookkeeper.mledger.impl; | ||
|
|
||
| import java.util.function.Supplier; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.apache.bookkeeper.client.BookKeeper; | ||
| import org.apache.bookkeeper.common.util.OrderedScheduler; | ||
| import org.apache.bookkeeper.mledger.ManagedLedgerConfig; | ||
| import org.apache.pulsar.common.naming.TopicName; | ||
|
|
||
| /** | ||
| * Working in progress until <a href="https://github.com/apache/pulsar/issues/16153">PIP-180</a> is finished. | ||
| * Currently, it works nothing different with ManagedLedgerImpl. | ||
| */ | ||
| @Slf4j | ||
| public class ShadowManagedLedgerImpl extends ManagedLedgerImpl { | ||
|
|
||
| private final TopicName shadowSource; | ||
| private final String sourceMLName; | ||
|
|
||
| public ShadowManagedLedgerImpl(ManagedLedgerFactoryImpl factory, BookKeeper bookKeeper, | ||
| MetaStore store, ManagedLedgerConfig config, | ||
| OrderedScheduler scheduledExecutor, | ||
| String name, final Supplier<Boolean> mlOwnershipChecker) { | ||
| super(factory, bookKeeper, store, config, scheduledExecutor, name, mlOwnershipChecker); | ||
| this.shadowSource = TopicName.get(config.getShadowSource()); | ||
| this.sourceMLName = shadowSource.getPersistenceNamingEncoding(); | ||
| } | ||
|
|
||
| @Override | ||
| synchronized void initialize(ManagedLedgerInitializeLedgerCallback callback, Object ctx) { | ||
| // TODO: ShadowManagedLedger has different initialize process from normal ManagedLedger, | ||
| // which is complicated and will be implemented in the next PRs. | ||
| super.initialize(callback, ctx); | ||
| } | ||
|
|
||
| public TopicName getShadowSource() { | ||
| return shadowSource; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowTopicTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.pulsar.broker.service.persistent; | ||
|
|
||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.apache.pulsar.broker.service.BrokerTestBase; | ||
| import org.apache.pulsar.common.naming.TopicName; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.AfterClass; | ||
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| @Slf4j | ||
| public class ShadowTopicTest extends BrokerTestBase { | ||
|
|
||
| @BeforeClass(alwaysRun = true) | ||
| @Override | ||
| protected void setup() throws Exception { | ||
| baseSetup(); | ||
| } | ||
|
|
||
| @AfterClass(alwaysRun = true) | ||
| @Override | ||
| protected void cleanup() throws Exception { | ||
| internalCleanup(); | ||
| } | ||
|
|
||
| @Test() | ||
| public void testNonPartitionedShadowTopicSetup() throws Exception { | ||
| String sourceTopic = "persistent://prop/ns-abc/source"; | ||
| String shadowTopic = "persistent://prop/ns-abc/shadow"; | ||
| //1. test shadow topic setting in topic creation. | ||
| admin.topics().createNonPartitionedTopic(sourceTopic); | ||
| admin.topics().createShadowTopic(shadowTopic, sourceTopic); | ||
| PersistentTopic brokerShadowTopic = | ||
| (PersistentTopic) pulsar.getBrokerService().getTopicIfExists(shadowTopic).get().get(); | ||
| Assert.assertEquals(brokerShadowTopic.getShadowSourceTopic().toString(), sourceTopic); | ||
| Assert.assertEquals(admin.topics().getShadowSource(shadowTopic), sourceTopic); | ||
|
|
||
| //2. test shadow topic could be properly loaded after unload. | ||
| admin.namespaces().unload("prop/ns-abc"); | ||
| Assert.assertTrue(pulsar.getBrokerService().getTopicReference(shadowTopic).isEmpty()); | ||
| Assert.assertEquals(admin.topics().getShadowSource(shadowTopic), sourceTopic); | ||
| brokerShadowTopic = (PersistentTopic) pulsar.getBrokerService().getTopicIfExists(shadowTopic).get().get(); | ||
| Assert.assertEquals(brokerShadowTopic.getShadowSourceTopic().toString(), sourceTopic); | ||
| } | ||
|
|
||
| @Test() | ||
| public void testPartitionedShadowTopicSetup() throws Exception { | ||
| String sourceTopic = "persistent://prop/ns-abc/source-p"; | ||
| String shadowTopic = "persistent://prop/ns-abc/shadow-p"; | ||
| String shadowTopicPartition = TopicName.get(shadowTopic).getPartition(0).toString(); | ||
|
|
||
| //1. test shadow topic setting in topic creation. | ||
| admin.topics().createPartitionedTopic(sourceTopic, 2); | ||
| admin.topics().createShadowTopic(shadowTopic, sourceTopic); | ||
| pulsarClient.newProducer().topic(shadowTopic).create().close();//trigger loading partitions. | ||
| PersistentTopic brokerShadowTopic = (PersistentTopic) pulsar.getBrokerService() | ||
| .getTopicIfExists(shadowTopicPartition).get().get(); | ||
| Assert.assertEquals(brokerShadowTopic.getShadowSourceTopic().toString(), sourceTopic); | ||
| Assert.assertEquals(admin.topics().getShadowSource(shadowTopic), sourceTopic); | ||
|
|
||
| //2. test shadow topic could be properly loaded after unload. | ||
| admin.namespaces().unload("prop/ns-abc"); | ||
| Assert.assertTrue(pulsar.getBrokerService().getTopicReference(shadowTopic).isEmpty()); | ||
|
|
||
| Assert.assertEquals(admin.topics().getShadowSource(shadowTopic), sourceTopic); | ||
| brokerShadowTopic = | ||
| (PersistentTopic) pulsar.getBrokerService().getTopicIfExists(shadowTopicPartition).get().get(); | ||
| Assert.assertEquals(brokerShadowTopic.getShadowSourceTopic().toString(), sourceTopic); | ||
| } | ||
|
|
||
|
|
||
| } |
Oops, something went wrong.