Skip to content

Commit

Permalink
[Improve][Standalone] Standalone Add param of --metadata-url for runi…
Browse files Browse the repository at this point in the history
…ng with metadata (#17077)
  • Loading branch information
liangyuanpeng authored and merlimat committed Oct 20, 2022
1 parent ae4b8e2 commit f0290fe
Showing 1 changed file with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ public boolean isHelp() {
description = "Directory for storing metadata")
private String metadataDir = "data/metadata";

@Parameter(names = { "--metadata-url" },
description = "Metadata store url")
private String metadataStoreUrl = "";

@Parameter(names = {"--zookeeper-port"}, description = "Local zookeeper's port",
hidden = true)
private int zkPort = 2181;
Expand Down Expand Up @@ -290,7 +294,7 @@ public void start() throws Exception {

if (!this.isOnlyBroker()) {
if (usingNewDefaultsPIP117) {
startBookieWithRocksDB();
startBookieWithMetadataStore();
} else {
startBookieWithZookeeper();
}
Expand Down Expand Up @@ -434,10 +438,13 @@ public void close() {
}
}


private void startBookieWithRocksDB() throws Exception {
log.info("Starting BK with RocksDb metadata store");
String metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
private void startBookieWithMetadataStore() throws Exception {
if (StringUtils.isBlank(metadataStoreUrl)){
log.info("Starting BK with RocksDb metadata store");
metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
} else {
log.info("Starting BK with metadata store:", metadataStoreUrl);
}
bkCluster = BKCluster.builder()
.metadataServiceUri(metadataStoreUrl)
.bkPort(bkPort)
Expand Down

0 comments on commit f0290fe

Please sign in to comment.