Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible code changes required for #13077 #13760

Closed
momo-jun opened this issue Jan 14, 2022 · 6 comments
Closed

Possible code changes required for #13077 #13760

momo-jun opened this issue Jan 14, 2022 · 6 comments
Assignees
@RobertIndie
Labels
help wanted lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@momo-jun
Copy link
Contributor

momo-jun commented Jan 14, 2022 •
edited
Loading

As per #13077, zookeeperServers and configurationStoreServers need to be renamed to metadataStoreUrl and configurationMetadataStoreUrl.

When implementing doc changes with a global search, I found the following files have parameter named zookeeper-servers and configuration-store-servers/configuration-store, which might need to be renamed as well.

Submit this issue to track whether the code needs to be changed like that in #13758.
image

Doc File1 with code sample:
image

Doc File2 with code sample:
image
@momo-jun momo-jun added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jan 14, 2022
@sijie sijie mentioned this issue Jan 14, 2022
Open
@RobertIndie
Copy link
Member

@codelipenghui I can work on it.

@gaozhangmin
Copy link
Contributor

I added metadataStoreUrl support for pulsar proxy and function_worker already.
#13777 #13782。 You just need update broker's doc.

@RobertIndie RobertIndie mentioned this issue Jan 17, 2022
Merged
1 task
@Anonymitaet Anonymitaet mentioned this issue Jan 18, 2022
Merged
3 tasks
@RobertIndie RobertIndie mentioned this issue Jan 21, 2022
Merged
1 task
codelipenghui pushed a commit that referenced this issue Jan 25, 2022
@RobertIndie
[WebSocket] Add configuration metadata store url setting in websocket (…
bd7e2a3 
…#13786)

Master Issue: #13760 

### Motivation

As per #13077, `configurationStoreServers` need to be renamed to `configurationMetadataStoreUrl`.

### Modifications

* Add `configurationMetadataStoreUrl` setting to websocket
* Deprecate `configurationStoreServers` in websocket
@RobertIndie RobertIndie mentioned this issue Jan 27, 2022
Merged
1 task
This was referenced Feb 7, 2022
Merged
Merged
@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@RobertIndie
Copy link
Member

Here is another PR related to this issue: #14384

@momo-jun momo-jun mentioned this issue Mar 2, 2022
Merged
1 task
@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@momo-jun
Copy link
Contributor Author

@RobertIndie @Anonymitaet I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertIndie RobertIndie

Labels
help wanted lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gaozhangmin @codelipenghui @hezhangjian @RobertIndie @momo-jun