Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] if dynamicConfig item in zk do not exist in broker, will fail for other dynamic config #17681

Closed
2 tasks done
leizhiyuan opened this issue Sep 16, 2022 · 0 comments · Fixed by #17705
Closed
2 tasks done
Assignees
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@leizhiyuan
Copy link
Contributor

leizhiyuan commented Sep 16, 2022

Search before asking

  • I searched in the issues and found nothing similar.

Version

master

Minimal reproduce step

we upgrade broker ,add a new dynamic config,then we have a,b,c in zk config

then we rollback broker, only a ,c exist in broker code,

Field configField = dynamicConfigurationMap.get(configKey).field;

dynamicConfigurationMap.get(configKey) will be null

WeChatWorkScreenshot_e20064b8-75c7-4ac8-bd1f-ea3e0e43657a

WeChatWorkScreenshot_8d3ad1a7-ba04-4380-9ccb-ff9713459987

What did you expect to see?

if dynamic config is null ,skip it

What did you see instead?

image

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants