Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix if dynamicConfig item in ZK do not exist in broker cause NPE. #17705

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Sep 17, 2022

Fixes #17681

Master Issue: #

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 17, 2022
@Technoboy- Technoboy- changed the title fix:if dynamicConfig item in zk do not exist in broker, failed [fix][broker] Fix if dynamicConfig item in ZK do not exist in broker cause NPE. Sep 19, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Sep 19, 2022
@codelipenghui codelipenghui merged commit 8bc02aa into apache:master Sep 19, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Sep 20, 2022
nodece pushed a commit that referenced this pull request Oct 31, 2022
* [fix][broker] Fix if dynamicConfig item in ZK do not exist in broker cause NPE (#17705)

* [fix][Authorization] Modify authorization to update topic's properties

Co-authored-by: Lei Zhiyuan <[email protected]>
congbobo184 pushed a commit that referenced this pull request Nov 14, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 14, 2022
congbobo184 pushed a commit that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] if dynamicConfig item in zk do not exist in broker, will fail for other dynamic config
5 participants