Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom URL scheme handlers #1212

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Support custom URL scheme handlers #1212

merged 1 commit into from
Feb 11, 2018

Conversation

maskit
Copy link
Member

@maskit maskit commented Feb 10, 2018

Motivation

Data URL scheme is implemented in Athenz auth plugin but it's not Athenz specific and should be able to use from other places.

Modifications

  • Generalize custom URL scheme support

Result

  • Be able to use Data URL scheme from anywhere
  • Be able to add other custom schemes easily

Note

I set milestone to 2.0.0 but it doesn't break any compatibility. It's just for release schedule.

@maskit maskit added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Feb 10, 2018
@maskit maskit added this to the 2.0.0-incubating milestone Feb 10, 2018
@maskit maskit self-assigned this Feb 10, 2018
merlimat
merlimat approved these changes Feb 10, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maskit
Copy link
Member Author

maskit commented Feb 11, 2018

Changed milestone to 1.22 since review has been done smoothly.

@maskit maskit merged commit ccbfbf8 into apache:master Feb 11, 2018
@maskit maskit deleted the custom_scheme_support branch October 23, 2018 14:19
@maskit maskit mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@hrsakai hrsakai Awaiting requested review from hrsakai

Assignees

@maskit maskit

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
1.22.0-incubating
Development

Successfully merging this pull request may close these issues.
2 participants
@maskit @merlimat