PIP-45: Handle session events and invalidations from single thread #12184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
rdhabalia,
jerrypeng,
hangc0276 and
codelipenghui
eolivelli
reviewed
Sep 25, 2021
...-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java
Show resolved
Hide resolved
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…pache#12184) * PIP-45: Handle session events and invalidations from single thread * Use iterator instead of stream * Removed synchronized
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Jan 9, 2023
…est !188) Squash merge branch 'release_2.8.1.4_fix_metadata' into 'release-2.8.1.4' Fixes #<xyz> ### Motivation chery pick了三个PR： PIP-45: Handle session events and invalidations from single thread (apache#12184) [fix][metadata] Set revalidateAfterReconnection true for certain failures apache#17664 [fix][metadata] Cleanup state when lock revalidation gets LockBusyException apache#17700 TAPD: --story=881235137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we receive session events from the MetadataStoreExtended implementation, we need to process them from a single thread to ensure that the locks and leader revalidations are not happening concurrently.
For example, it possible to receive a
SessionEvent.Reconnectedimmediately followed by aSessionEvent.SessionReestablished. In this case we need to first finish processing the 1st event and complete all the revalidations, then proceeding to the other event, otherwise we'll be having multiple revalidations in flight.