[fix][txn] Transaction cumulative ack redeliver change #14371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
merlimat,
Jason918,
hangc0276,
eolivelli,
315157973,
codelipenghui and
gaoran10
|
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs? |
|
@congbobo184:Thanks for providing doc info! |
eolivelli
previously approved these changes
Feb 18, 2022
added 3 commits
February 18, 2022 19:18
…tion_cumulative_abort_redeliver_message
|
The pr had no activity for 30 days, mark with Stale label. |
…tion_cumulative_abort_redeliver_message
congbobo184
changed the title
…tion_cumulative_abort_redeliver_message
gaoran10
reviewed
May 23, 2022
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
Show resolved
Hide resolved
liangyepianzhou
approved these changes
May 24, 2022
…tion_cumulative_abort_redeliver_message # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
added 2 commits
July 12, 2022 20:12
…tion_cumulative_abort_redeliver_message
…tion_cumulative_abort_redeliver_message
1 task
codelipenghui
added
the
release/important-notice
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
apache#10478 ### Motivation since apache#10478 merged, we should change the cumulative ack with transaction abort redeliver logic. We can't redeliver unCumulativeAck message by the server because the client will receive the new message and ack then will receive the old message they abort. in this case: 1. we have 5 message 2. cumulative ack 3 messages with the transaction 3. we abort this transaction 4. server redeliver message by the current consumer_epoch 5. the client will not filter the 4 or 5 messages, because in apache#10478 we don't change the client consumer epoch 6. client cumulative ack 4 5 with transaction and commit will lose the 1 2 3 messages and the consume message, not in order. ### Modifications don't redeliver any cumulative ack messages, it will do by user self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10478
Motivation
since #10478 merged, we should change the cumulative ack with transaction abort redeliver logic. We can't redeliver unCumulativeAck message by the server because the client will receive the new message and ack then will receive the old message they abort.
in this case:
Modifications
don't redeliver any cumulative ack messages, it will do by user self
Verifying this change
don't need to add a test, the original test has been overwritten
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Does this pull request introduces a new feature? (yes)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
doc-not-needed