[Issue 14505] PIP-145: Enable evaluating subscription pattern on broker side #14804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 1 of PIP-145: Improve performance of regex subscriptions This change covers applying subscription pattern on broker side and using hashes to skip updates when nothing changed.
|
@andrasbeni:Thanks for your contribution. For this PR, do we need to update docs? |
merlimat
added
doc-not-needed
hangc0276
requested review from
eolivelli,
michaeljmarshall,
merlimat,
hangc0276,
315157973,
codelipenghui and
Jason918
hangc0276
added
type/feature
merlimat
approved these changes
Mar 30, 2022
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicList.java
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicList.java
Outdated
Show resolved
Hide resolved
Jason918
reviewed
Mar 30, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
hangc0276
reviewed
Mar 31, 2022
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplTest.java
Show resolved
Hide resolved
Lannnnh
pushed a commit
to Lannnnh/pulsar
that referenced
this pull request
Apr 6, 2022
…er side (apache#14804) * PIP-145: Enable evaluating subscription pattern on broker side This is part 1 of PIP-145: Improve performance of regex subscriptions This change covers applying subscription pattern on broker side and using hashes to skip updates when nothing changed. * TopicList class: make it utility, precompile pattern * Log when client provided pattern is too long * Fix code style error Co-authored-by: Matteo Merli <[email protected]>
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…er side (apache#14804) * PIP-145: Enable evaluating subscription pattern on broker side This is part 1 of PIP-145: Improve performance of regex subscriptions This change covers applying subscription pattern on broker side and using hashes to skip updates when nothing changed. * TopicList class: make it utility, precompile pattern * Log when client provided pattern is too long * Fix code style error Co-authored-by: Matteo Merli <[email protected]>
Anonymitaet
added
doc-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #14505
Motivation
This is part 1 of PIP-145: Improve performance of regex subscriptions
Modifications
This change covers applying subscription pattern on broker side and
using hashes to skip updates when nothing changed.
Verifying this change
This change added unit tests
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)