-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Make splitNamespaceBundle and getTopicHashPositions async #16411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
requested review from
aloyszhang,
codelipenghui,
nodece and
Technoboy-
July 6, 2022 06:44
gaozhangmin
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
area/admin
labels
Jul 6, 2022
/pulsarbot run-failure-checks |
gaozhangmin
force-pushed
the
async3
branch
2 times, most recently
from
July 11, 2022 10:27
b48abcc
to
fcd323b
Compare
/pulsarbot run-failure-checks |
gaozhangmin
force-pushed
the
async3
branch
2 times, most recently
from
July 13, 2022 09:46
c137de1
to
5f4a9cb
Compare
Technoboy-
approved these changes
Jul 13, 2022
nodece
requested changes
Jul 13, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
/pulsarbot run-failure-checks |
nodece
approved these changes
Jul 14, 2022
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
…Namespaces.java Co-authored-by: Zixuan Liu <[email protected]>
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/admin
doc-not-needed
Your PR changes do not impact docs
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make the below method async:
getBundlesData
splitNamespaceBundle
getTopicHashPositions
setPublishRate
getPublishRate
setDispatchRate
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed