Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker][PIP-149]Make GetMessageIdByTimestamp pure async #16446

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[improve][broker][PIP-149]Make GetMessageIdByTimestamp pure async #16446

merged 2 commits into from
Jul 13, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jul 7, 2022

Master Issue: #14365

Motivation

Modifications

  • Make internalGetMessageIdByTimestamp async

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@AnonHxy AnonHxy changed the title [improve][broker][PIP-149]Make GetMessageIdByTimestamp async [improve][broker][PIP-149]Make GetMessageIdByTimestamp pure async Jul 7, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 7, 2022

/pulsarbot run-failure-checks

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 7, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 8, 2022

/pulsarbot run-failure-checks

1 similar comment
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 8, 2022

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 11, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Jul 11, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 11, 2022

/pulsarbot run-failure-checks

@Technoboy-
Copy link
Contributor

/pulsarbot run-failure-checks

@AnonHxy AnonHxy force-pushed the GetMessageIdByTimestampAsync branch from 20cf345 to c736080 Compare July 13, 2022 01:29
@Technoboy- Technoboy- merged commit 5ea139f into apache:master Jul 13, 2022
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
@AnonHxy @weimob-wuxuanqi
[improve][broker][PIP-149]Make GetMessageIdByTimestamp pure async (ap…
38d8337 
…ache#16446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@Jason918 Jason918 Jason918 approved these changes

Assignees

@AnonHxy AnonHxy

Labels
area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AnonHxy @Technoboy- @Jason918 @mattisonchao