Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor][java-client] Reduce code duplication in GET requests in admin client #17023

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

andrasbeni
Copy link
Contributor

@andrasbeni andrasbeni commented Aug 9, 2022

Motivation

This is a continuation of #16377 to reduce code repetition in the admin client.

Modifications

Move the functionality implemented in InvocationCallbacks to a common place.
Hide creation of CompletableFuture to be consistent with other HTTP method
implementations (e.g. asyncPutRequest).

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed
    This is pure refactoring, no behavior is changed.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

@andrasbeni Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 13, 2022
@codelipenghui codelipenghui added area/client type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Aug 13, 2022
@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

2 similar comments
@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@andrasbeni
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@andrasbeni
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit d14b3e3 into apache:master Sep 14, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants