Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build][sql] Make pulsar-trino-disto self-contained #17062

Merged
merged 27 commits into from
Sep 9, 2022
Merged

[build][sql] Make pulsar-trino-disto self-contained #17062

merged 27 commits into from
Sep 9, 2022

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Aug 11, 2022 •
edited
Loading

Master issue #17137

  • doc-not-needed

@tisonkun tisonkun marked this pull request as draft August 11, 2022 06:26
@tisonkun
update related refs
a3454a6 
Signed-off-by: tison <[email protected]>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 11, 2022
@tisonkun
fix relpath
fa875a7 
Signed-off-by: tison <[email protected]>
@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 11, 2022
@tisonkun
Copy link
Member Author

Seems good. Let me handle all the remaining renaming things and try to prepare a PIP.

@tisonkun tisonkun mentioned this pull request Aug 17, 2022
Closed
1 task
eolivelli
eolivelli requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overall agree with the patch.
I have left some comments about the PR style

buildtools/src/main/resources/pulsar/checkstyle.xml Outdated Show resolved Hide resolved
distribution/server/src/assemble/bin.xml Outdated Show resolved Hide resolved
@sijie sijie mentioned this pull request Aug 17, 2022
Open
@tisonkun tisonkun mentioned this pull request Aug 18, 2022
Merged
1 task
@tisonkun tisonkun marked this pull request as ready for review August 29, 2022 13:30
@tisonkun tisonkun mentioned this pull request Aug 29, 2022
Merged
1 task
@tisonkun
Copy link
Member Author

tisonkun commented Sep 5, 2022

/pulsarbot run-failure-checks

1 similar comment
@tisonkun
Copy link
Member Author

tisonkun commented Sep 5, 2022

/pulsarbot run-failure-checks

codelipenghui
codelipenghui approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

LGTM, I have tried on my laptop. Pulsar SQL works great.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 6, 2022

Thanks for your reviews! I think this patch is ready for merge. @eolivelli @codelipenghui @nicoloboschi could you help with performing the merge?

After it's merged I'll update the corresponding docs and then we can close PIP-200 as completed.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

/pulsarbot run-failure-checks

1 similar comment
@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

It seems broker group 2 tests don't like me, lol. Update branch and rerun.

@tisonkun
Copy link
Member Author

tisonkun commented Sep 7, 2022

Now broker group 1 tests don't like me :(

Rerun later >_<

@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

1 similar comment
@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

3 similar comments
@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Sep 8, 2022

@nicoloboschi I think the unrequired check status is due to your action. Do you think it's good to merge this PR now?

@tisonkun
Copy link
Member Author

tisonkun commented Sep 9, 2022

Finally!

@codelipenghui @nicoloboschi could you help with merging this XD

@nicoloboschi nicoloboschi merged commit 743b038 into apache:master Sep 9, 2022
@tisonkun tisonkun deleted the trino-disto-self-contain branch September 9, 2022 18:09
@tisonkun tisonkun mentioned this pull request Sep 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@nodece nodece nodece approved these changes

@maxsxu maxsxu maxsxu approved these changes

@MarvinCai MarvinCai MarvinCai approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@tisonkun tisonkun

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tisonkun @eolivelli @codelipenghui @MarvinCai @maxsxu @nodece @nicoloboschi