Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata #17077

Merged
merged 5 commits into from
Sep 26, 2022
Merged

[Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata #17077

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3674174
Standalone Add param of --metadata-url for runing with metadata
liangyuanpeng Aug 12, 2022
430b3e7
Fix code style
liangyuanpeng Sep 8, 2022
c3f1ca0
Merge remote-tracking branch 'origin/master' into Standalone_with_met…
liangyuanpeng Sep 8, 2022
497e238
Fix code review
liangyuanpeng Sep 12, 2022
d575965
Merge remote-tracking branch 'origin/master' into Standalone_with_met…
liangyuanpeng Sep 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ public boolean isHelp() {
description = "Directory for storing metadata")
private String metadataDir = "data/metadata";

@Parameter(names = { "--metadata-url" },
description = "Metadata store url")
private String metadataStoreUrl = "";

@Parameter(names = {"--zookeeper-port"}, description = "Local zookeeper's port",
hidden = true)
private int zkPort = 2181;
Expand Down Expand Up @@ -290,7 +294,7 @@ public void start() throws Exception {

if (!this.isOnlyBroker()) {
if (usingNewDefaultsPIP117) {
startBookieWithRocksDB();
startBookieWithMetadataStore();
} else {
startBookieWithZookeeper();
}
Expand Down Expand Up @@ -434,10 +438,13 @@ public void close() {
}
}


private void startBookieWithRocksDB() throws Exception {
log.info("Starting BK with RocksDb metadata store");
String metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
private void startBookieWithMetadataStore() throws Exception {
if(StringUtils.isBlank(metadataStoreUrl)){
log.info("Starting BK with RocksDb metadata store");
metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
}else{
log.info("Starting BK with metadata store:",metadataStoreUrl);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format this code block according to our code style settings. Briefly, add necessary blanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review and i'm busy for otherthing, pick it up in the next week maybe.

bkCluster = BKCluster.builder()
.metadataServiceUri(metadataStoreUrl)
.bkPort(bkPort)
Expand Down