[improve][broker][PIP-149]make deletePersistence method async in Namespaces #17206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
requested review from
codelipenghui,
mattisonchao and
nodece
and removed request for
codelipenghui,
mattisonchao and
nodece
AnonHxy
added
doc-not-needed
AnonHxy
reviewed
Aug 22, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
Pomelongan
requested review from
AnonHxy
and removed request for
codelipenghui,
mattisonchao and
nodece
AnonHxy
reviewed
Aug 22, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
AnonHxy
approved these changes
Aug 26, 2022
|
@Pomelongan Please fix CI failure. |
HQebupt
approved these changes
Aug 28, 2022
|
/pulsarbot run-failure-checks |
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 8, 2022
…spaces (apache#17206) * make deletePersistence method async in Namespaces * update comment * remove irrelevant import * reduce unnecessary exceptions * remove redundant exception log printing logic Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 8140080)
dlg99
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 8, 2022
…spaces (apache#17206) * make deletePersistence method async in Namespaces * update comment * remove irrelevant import * reduce unnecessary exceptions * remove redundant exception log printing logic Co-authored-by: huangzegui <[email protected]> (cherry picked from commit 8140080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #14365
Verifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed