[feature][client-cpp] Support inclusive seek for cpp client #17209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/feature
Demogorgon314
force-pushed
the
Demogorgon314/cpp-inclusive-seek
branch
2 times, most recently
from
32274c0 to
4af9b85
Compare
|
This feature is based on @BewareMyPower 's branch and added some missing parts. Thanks @BewareMyPower 's great work! |
Demogorgon314
force-pushed
the
Demogorgon314/cpp-inclusive-seek
branch
2 times, most recently
from
b722e60 to
7aa0caa
Compare
Demogorgon314
force-pushed
the
Demogorgon314/cpp-inclusive-seek
branch
from
7aa0caa to
55278a0
Compare
|
Could you resolve the conflicts? |
Demogorgon314
force-pushed
the
Demogorgon314/cpp-inclusive-seek
branch
from
6e92102 to
6b00973
Compare
BewareMyPower
requested changes
Sep 8, 2022
Demogorgon314
force-pushed
the
Demogorgon314/cpp-inclusive-seek
branch
from
0ba3d01 to
2320b95
Compare
BewareMyPower
approved these changes
Sep 15, 2022
|
@RobertIndie @merlimat Could any of you leave a 2nd review? |
|
Ping @RobertIndie @merlimat |
RobertIndie
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17186
Motivation
There are some cases in which it is useful to be able to include current
position of the message when reset of cursor was made.
Modifications
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)