Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature][broker] PIP-204: Extensions for broker interceptor #17269

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[feature][broker] PIP-204: Extensions for broker interceptor #17269

merged 1 commit into from
Sep 15, 2022

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Aug 25, 2022 •
edited
Loading

Fixes #17267

Motivation

extend BrokerInterceptor, details see #17267

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: ( yes)
  • The schema: ( no)
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: ( no)
  • The admin cli options: ( no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 25, 2022
@codelipenghui
Copy link
Contributor

@aloyszhang It should be a public API change, the proposal is required so that we can make everyone on the same page that how the new API will be used by users.

@aloyszhang
Copy link
Contributor Author

aloyszhang commented Aug 25, 2022 •
edited
Loading

@codelipenghui Thanks, I'll send a discuss email to dev soon.

@aloyszhang
Copy link
Contributor Author

Update PIP discuss thread : https://lists.apache.org/thread/3zgpbxffo7gzsb5mdh0sk2rq27bgw2bo
cc @codelipenghui

@aloyszhang aloyszhang requested a review from Jason918 August 26, 2022 02:23
@aloyszhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@aloyszhang
Copy link
Contributor Author

aloyszhang commented Sep 5, 2022 •
edited
Loading

The vote(https://lists.apache.org/thread/ckxqgoyjkqgbp6szn2vh9ynzbsjxm3yy) for this PIP is now passed.
PTAL @codelipenghui @Jason918 @eolivelli @Technoboy- , thanks.

@aloyszhang aloyszhang changed the title extend BrokerInterceptor for more scenes [feature][broker]extend BrokerInterceptor for more scenes Sep 5, 2022
@AnonHxy
Copy link
Contributor

AnonHxy commented Sep 6, 2022

LGTM

wolfstudy
wolfstudy approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

eolivelli
eolivelli approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aloyszhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@aloyszhang
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Jason918 Jason918 added type/feature The PR added a new feature or issue requested a new feature area/broker labels Sep 8, 2022
@Jason918 Jason918 changed the title [feature][broker]extend BrokerInterceptor for more scenes [feature][broker] PIP-204: Extensions for broker interceptor Sep 8, 2022
codelipenghui
codelipenghui reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have removed the test coverage?

pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/BrokerInterceptors.java Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java Outdated
Comment on lines 329 to 331
if (brokerInterceptor != null) {
brokerInterceptor.producerClosed(this, producer, producer.getMetadata());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't need if check here?

@aloyszhang
Copy link
Contributor Author

I think you have removed the test coverage?

which part do you mean？

@aloyszhang aloyszhang force-pushed the interceptor branch 2 times, most recently from 06a42b3 to b264a92 Compare September 9, 2022 12:58
@codelipenghui codelipenghui merged commit c7b7146 into apache:master Sep 15, 2022
codertmy pushed a commit to codertmy/pulsar that referenced this pull request Sep 16, 2022
@aloyszhang
[feature][broker] PIP-204: Extensions for broker interceptor (apache#…
df90351 
…17269)
@aloyszhang aloyszhang deleted the interceptor branch November 30, 2022 01:44
@BewareMyPower BewareMyPower mentioned this pull request Sep 26, 2023
Merged
4 tasks
@nodece nodece mentioned this pull request Nov 1, 2023
Merged
4 tasks
@nodece nodece added this to the 3.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

@eolivelli eolivelli eolivelli approved these changes

@Jason918 Jason918 Jason918 approved these changes

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

@aloyszhang aloyszhang

Labels
area/broker doc-not-needed Your PR changes do not impact docs type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

PIP-204 Extensions for broker interceptor
7 participants
@aloyszhang @codelipenghui @AnonHxy @Jason918 @eolivelli @wolfstudy @nodece