-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client-c++]Support include message header size when check maxMessageSize #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odd, why is the java client compilation failed?
|
See: #17300 |
shibd
reviewed
Sep 3, 2022
shibd
approved these changes
Sep 3, 2022
BewareMyPower
requested changes
Sep 7, 2022
coderzc
force-pushed
the
check_message_header_cpp
branch
from
September 8, 2022 08:30
c4d2953
to
4ea30f5
Compare
BewareMyPower
approved these changes
Sep 15, 2022
@RobertIndie PTAL. |
@RobertIndie @merlimat @Demogorgon314 Could any of you leave a 2nd review? |
RobertIndie
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #17188
Motivation
See: #17188
Modifications
Support include message header size when check maxMessageSize for cpp client
Verifying this change
This change is already covered by existing tests, such as testMaxMessageSize、testNoBatchMaxMessageSize、testChunkingMaxMessageSize.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)