-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker]prevent partitioned metadata lookup request when broker is closing #17315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
approved these changes
Aug 28, 2022
AnonHxy
approved these changes
Aug 28, 2022
2 tasks
/pulsarbot run-failure-checks |
codelipenghui
requested review from
BewareMyPower,
michaeljmarshall,
mattisonchao,
congbobo184,
gaoran10 and
Technoboy-
August 30, 2022 01:49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to cover the new changes.
HQebupt
force-pushed
the
handlePartitionMetadaEx
branch
from
September 10, 2022 15:11
079efbb
to
2258e57
Compare
@codelipenghui PTAL when you are available. |
michaeljmarshall
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BewareMyPower
approved these changes
Sep 12, 2022
AnonHxy
reviewed
Sep 13, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java
Outdated
Show resolved
Hide resolved
LGTM with minor comment |
Technoboy-
pushed a commit
that referenced
this pull request
Sep 26, 2022
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…2.9-wxg-release' (merge request !53) [improve][broker] fix broker irrational behavior when it is closing (apache#17085) 1. [[improve][broker]fix broker irrational behavior when it is closing by HQebupt · Pull Request apache#17085 · apache/pulsar](apache#17085) 2. [[improve][broker]prevent new connection request when broker is closing by HQebupt · Pull Request apache#17314 · apache/pulsar](apache#17314) 3. [[improve][broker]prevent partitioned metadata lookup request when broker is closing by HQebupt · Pull Request apache#17315 · apache/pulsar](apache#17315)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 26, 2022
…ker is closing (apache#17315) (cherry picked from commit 256bd68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inspired by #17085
When the leader broker is closing, and the client will reconnect and redo lookup, resulting in unexpected results.
Therefore, it is necessary to check the status of the broker when handling requests, including connect\lookup\partitioned metadata.
The following is the interaction workflow between consumer and broker.
The following screenshot is the interaction workflow between producer and broker.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-not-needed