-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature][cpp] Expose Chunking configuration C API #17332
Conversation
@RobertIndie Please provide a correct documentation label for your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better not to use C++ specific semantics in tests for C API. The C interfaces use int
as a boolean value so we'd better use 1 and 0 to represent true and false.
Motivation
Expose Chunking configuration C API
Modifications
chunking_enabled
,max_pending_chunked_message
,auto_ack_oldest_chunked_message_on_queue_full
to C API.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)