Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][cpp] Expose Chunking configuration C API #17332

Merged
merged 6 commits into from
Sep 14, 2022

Conversation

RobertIndie
Copy link
Member

Motivation

Expose Chunking configuration C API

Modifications

  • Expose chunking_enabled, max_pending_chunked_message , auto_ack_oldest_chunked_message_on_queue_full to C API.
  • Add unit tests for C API of producer configuration and consumer configuration.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie added type/feature The PR added a new feature or issue requested a new feature component/client-c++ labels Aug 29, 2022
@RobertIndie RobertIndie self-assigned this Aug 29, 2022
@github-actions
Copy link

@RobertIndie Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@RobertIndie RobertIndie added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Aug 29, 2022
Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better not to use C++ specific semantics in tests for C API. The C interfaces use int as a boolean value so we'd better use 1 and 0 to represent true and false.

pulsar-client-cpp/tests/c/c_ProducerConfigurationTest.cc Outdated Show resolved Hide resolved
pulsar-client-cpp/tests/c/c_ConsumerConfigurationTest.cc Outdated Show resolved Hide resolved
pulsar-client-cpp/tests/ConsumerConfigurationTest.cc Outdated Show resolved Hide resolved
pulsar-client-cpp/tests/ProducerConfigurationTest.cc Outdated Show resolved Hide resolved
@RobertIndie RobertIndie merged commit 05a884c into apache:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants