Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][CI] Fix broken CI build: exclude **/*.md files from license and rat check #17339

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Aug 29, 2022

Motivation

The master branch build is broken in CI after #17270 changes. The rat check fails with 2 errors.

Modifications

**/*.md files should be excluded from license checks.

  • doc-not-needed

@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug doc-not-needed Your PR changes do not impact docs area/ci labels Aug 29, 2022
@lhotari lhotari changed the title [fix][CI] Exclude **/*.md files from license and rat check [fix][CI] Fix broken CI build: exclude **/*.md files from license and rat check Aug 29, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Aug 29, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Aug 29, 2022
@apache apache deleted a comment from github-actions bot Aug 29, 2022
@apache apache deleted a comment from github-actions bot Aug 29, 2022
@dlg99 dlg99 merged commit 358b718 into apache:master Aug 29, 2022
@dlg99 dlg99 added this to the 2.11.0 milestone Aug 29, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Aug 29, 2022
@codelipenghui
Copy link
Contributor

@dlg99 Only the master branch is broken, so I moved the milestone to 2.12.0

@tisonkun
Copy link
Member

@lhotari may I ask why this failure isn't detected before #17270 merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants