[feat][broker]PIP-180 ShadowTopic - Part IV - Add Shadow Replicator #17371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
Jason918
requested review from
eolivelli,
codelipenghui and
AnonHxy
and removed request for
eolivelli and
codelipenghui
AnonHxy
reviewed
Sep 6, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
|
@AnonHxy Addressed comments. PTAL |
AnonHxy
reviewed
Sep 6, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
AnonHxy
approved these changes
Sep 7, 2022
|
LGTM now |
|
/pulsarbot run-failure-checks |
Jason918
added
type/feature
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ShadowReplicator.java
Outdated
Show resolved
Hide resolved
...r-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowReplicatorTest.java
Show resolved
Hide resolved
...r-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowReplicatorTest.java
Outdated
Show resolved
Hide resolved
...r-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowReplicatorTest.java
Outdated
Show resolved
Hide resolved
|
@codelipenghui PTAL |
codelipenghui
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16153
Motivation
Add ShadowReplicator.
Modifications
PersistentTopic#shadowReplicators, most of its management just followsPersistentTopic#replicatorsShadowReplicatorVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
None
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededInternal implementation.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)