[improve][test] Move testAutoSchemaFunction and testAvroSchemaFunction to Java functions IT #17372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
changed the title
Technoboy-
approved these changes
Sep 1, 2022
nicoloboschi
approved these changes
Sep 1, 2022
|
@cbornet checksyle fails |
cbornet
force-pushed
the
move-testAutoSchemaFunction
branch
from
81f40c2 to
79a6010
Compare
fixed, PTAL again. |
cbornet
force-pushed
the
move-testAutoSchemaFunction
branch
2 times, most recently
from
5f82ee4 to
76a6f1c
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
cbornet
force-pushed
the
move-testAutoSchemaFunction
branch
from
76a6f1c to
0a4abe4
Compare
cbornet
force-pushed
the
move-testAutoSchemaFunction
branch
from
0a4abe4 to
81939be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently testAutoSchemaFunction and testAvroSchemaFunction are run for Go and Python tests.
But these tests only run on the Java runtime so it's useless to run them 3 times.
Moving them to Java function tests will save some precious CI resources.
Modifications
trivial
Verifying this change
This change is already covered by existing tests, such as testAutoSchemaFunction and testAvroSchemaFunction.
Does this pull request potentially affect one of the following parts:
no
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededtest
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)