[improve][test] Add integration test for entry filters #17396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
gaoran10
reviewed
Sep 8, 2022
| String messageValue = producer.getProducerName() + "-" + i; | ||
| MessageId messageId = producer.newMessage() | ||
| .value(messageValue) | ||
| .property("filter_property", messageValue) |
There was a problem hiding this comment.
Maybe we can use the static param FILTER_PROPERTY of the class PatternEntryFilter.java as the key here.
There was a problem hiding this comment.
I agree it would be cleaner, but I don't think this alone is a strong enough reason to introduce a dependency between the two maven modules these classes are in, so I decided to duplicate this string instead. Let me know what you think.
gaoran10
approved these changes
Sep 8, 2022
|
/pulsarbot rerun pulsar-ci-checks-completed |
10 tasks
|
/pulsarbot rerun pulsar-ci-checks-completed |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 16, 2022
codertmy
pushed a commit
to codertmy/pulsar
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #17132
Motivation
Add tests to prevent unintended changes to how the broker uses Entry Filters.
Modifications
PatternEntryFilter.Verifying this change
This change added tests and can be verified as follows:
Added integration tests for entry filters
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
doc-not-neededThis change only affects tests