[transactions] Fix minor leak of FlushContext #17399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli Please provide a correct documentation label for your PR. |
codelipenghui
approved these changes
Sep 2, 2022
eolivelli
added
doc-not-needed
coderzc
approved these changes
Sep 2, 2022
eolivelli
force-pushed
the
fix/flushcontext-leak
branch
from
8339a9e to
0c4dbba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a chance that FlushContext is not recycled in case of failure and "flushContext.asyncAddArgsList" is empty or null.
Modifications
Fix the code
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.